UN-3377 Add debug check for missing request metadata.#341
Merged
andreidenissov-cog merged 1 commit intomainfrom Jul 31, 2025
Merged
UN-3377 Add debug check for missing request metadata.#341andreidenissov-cog merged 1 commit intomainfrom
andreidenissov-cog merged 1 commit intomainfrom
Conversation
andreidenissov-cog
force-pushed
the
ASD-UN-3377-debug-check01
branch
from
b4f541e to
b7dd0fa
Compare
| self.logger = HttpLogger(forwarded_request_metadata) | ||
| self.network_storage_dict: Dict[str, AgentNetworkStorage] = network_storage_dict | ||
| self.show_absent: bool = os.environ.get("SHOW_ABSENT_METADATA") is not None | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Set the debug mode from env variable.
d1donlydfink
approved these changes
Jul 30, 2025
Collaborator
d1donlydfink
left a comment
d1donlydfink
left a comment
There was a problem hiding this comment.
Clever way to see where the fault lies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds temporary debug logging for incoming requests with missing metadata.
We are hoping to find out where exactly a problem originates - on the client side
or maybe in the server internals.
Debug mode is controlled by SHOW_ABSENT_METADATA env variable which should be set to enable it.